Skip to content

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Mar 10, 2025

@dakrone
Copy link
Member Author

dakrone commented Mar 10, 2025

Not included in this PR (let me know if they should be) are the following changes brought about by make generate:

Unstaged changes (2)
modified   package-lock.json (binary)
modified   package.json
@@ -1,5 +1,6 @@
 {
   "dependencies": {
+    "@redocly/cli": "^1.33.0",
     "@stoplight/spectral-cli": "^6.14.2"
   }
 }

Additionally, it would be good if the template for a new PR were encapsulated into a "Contributing" file, as per Github's recommendations.

@dakrone dakrone requested a review from pquentin March 10, 2025 20:10
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

❯ make validate branch=main api=indices.get_data_stream
Validating endpoints
Validating indices.get_data_stream
indices.get_data_stream request has been successfully validated!

✔ 11 out of 11 test request cases are passing.
✔ 11 out of 11 test response cases are passing.

@pquentin pquentin added the skip-backport This pull request should not be backported label Mar 14, 2025
@pquentin
Copy link
Member

Validation report is also available here: #3958 (comment) (I had to open a new PR because yours was opened from a fork, not a branch, which we don't support for security reasons.)

@pquentin pquentin merged commit 08117fb into elastic:main Mar 14, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants